I do have 2 questions tho:

• is it even a valid configuration, if not feel free to point out edge cases to add
• the validation looks similar to a callback hell, hopefully you have wide enough screens, please call me out if it needs refactor (update: definitely needs to be refactored, I forgot how to rust 😿 )

Appreciate

Alright @markkovari you should be good to proceed with this one 😄 Just take note of the newer structure where the source block is the recommended route, and source_config is a backwards compatible field. I would recommend just validating that the source: config: block isn't present, since we want to deprecate source_config out in a future release anyways

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

Just a question here: since v0.13.0 the fields are deprecated (source_config) and (target_config), this is still relevant right?
Currently the yaml parsing into the structure is always None so it is doable by the casual yaml traversing/parsing method.
And this should be even related to this too:
wasmCloud/wasmCloud#2862

Hey @markkovari , yep I think it's still relevant here just failing when source.config is present instead of source_config if that makes sense 😄

It would be best to do the validation in a place where we can just use the same logic for both

Thanks will add this changes tomorrow early. But still not sure if this is the expected behavior or not. WADM is so much more magical than wasmCloud 😄

This is a great start @markkovari. There is definitely more we could add to this part of validation, but even having something that warns about deprecation is great

@thomastaylor312 @brooksmtownsend sorry for the delay
unfortunately the solution is a bit hacky 😅 , but the serialization is always making the yaml parsed objects link traits' sounce_config and target_config None, not sure if it is possible to do it the "nice way" just like the other steps

Thanks